LG-4138 | LG-4150: [CCP] Select updates #2313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: eaac093 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Size Change: -425 B (0%) Total Size: 1.3 MB
ℹ️ View Unchanged
|
stephl3
force-pushed
the
steph/ccp-select
branch
from
a43d1b8
to
595e5e0
Compare
6 tasks
bruugey
reviewed
Apr 11, 2024
bruugey
reviewed
Apr 11, 2024
bruugey
reviewed
Apr 11, 2024
bruugey
reviewed
Apr 11, 2024
bruugey
reviewed
Apr 11, 2024
bruugey
reviewed
Apr 11, 2024
bruugey
reviewed
Apr 11, 2024
bruugey
reviewed
Apr 11, 2024
bruugey
reviewed
Apr 11, 2024
bruugey
reviewed
Apr 11, 2024
TheSonOfThomp
approved these changes
Apr 18, 2024
stephl3
force-pushed
the
steph/ccp-select
branch
from
e7fd068
to
eec1d40
Compare
stephl3
force-pushed
the
steph/ccp-select
branch
from
eec1d40
to
07d5189
Compare
stephl3
force-pushed
the
steph/ccp-select
branch
from
07d5189
to
21c10d9
Compare
TheSonOfThomp
approved these changes
Apr 24, 2024
stephl3
force-pushed
the
steph/ccp-inputs
branch
from
3b444b2
to
4dff042
Compare
stephl3
force-pushed
the
steph/ccp-select
branch
from
21c10d9
to
8125a8d
Compare
6 tasks
stephl3
added a commit
that referenced
this pull request
Apr 25, 2024
* Update placeholder text color * Update spacing * Remove error icon from inside MenuButton * Add error icon and default error message below select * StateFeedback with errorMessage and successMessage * Select changeset * Refactor
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 26, 2024
* Fix lightModeBorderColors typo * Use color tokens in typography * Fix background disabled token * Add and export DEFAULT_MESSAGES constant and FormFieldFeedback * Use FormFieldFeedback and tokens in form-field * Fix lint * Fix tests * Changesets * Correct typeScales.large.lineHeight * Export color token types * FormField feedback * FormFieldFeedback takes optional baseFontSize prop * LG-4133 | LG-4140: [CCP] Combobox updates (#2300) * [CCP] Combobox updates * Combobox changeset * Clean up styling * LG-4138 | LG-4150: [CCP] Select updates (#2313) * Update placeholder text color * Update spacing * Remove error icon from inside MenuButton * Add error icon and default error message below select * StateFeedback with errorMessage and successMessage * Select changeset * Refactor * LG-4134 | LG-4142: [CCP] NumberInput updates (#2301) * [CCP] NumberInput updates * NumberInput changeset * Use typeScales for unit selector button * Remove redundant stories * LG-4135 | LG-4151: [CCP] PasswordInput updates (#2310) * [CCP] PasswordInput changes * PasswordInput changeset * Refactor * Add types tests * Add to README * Lint * Remove redundant styles * Consistent spacing for components using caret
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✍️ Proposed changes
errorMessagevalidstate withsuccessMessageprop🎟 Jira ticket: LG-4138
✅ Checklist
For bug fixes, new features & breaking changes
yarn changesetand documented my changesFor new components
🧪 How to test changes
Figma: https://www.figma.com/file/WmbvStSle8GtLg5RqEt2oh/Component-Consistency-Project?type=design&node-id=59%3A15314&mode=design&t=Wf5VD9qqs9EmPGXy-1
Review storybook and chromatic